Skip to content

Conversation

ratbeard
Copy link
Contributor

What:

#98 prints out html when toContainHTML matcher fails

Why:

Before:
 2019-04-29 at 12 57 51 PM

After:
 2019-04-29 at 12 57 36 PM

How:

Checklist:

  • [] Documentation n/a
  • [] Tests n/a
  • Updated Type Definitions n/a
  • Ready to be merged
  • Added myself to contributors table

@gnapse gnapse merged commit 3f85527 into testing-library:master Apr 30, 2019
@gnapse
Copy link
Member

gnapse commented Apr 30, 2019

🎉 This PR is included in version 3.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rikkit
Copy link

rikkit commented Jun 4, 2020

To match the behaviour of other matchers it would be nice if this also printed the value of expected. Would a PR like that be accepted?

@gnapse
Copy link
Member

gnapse commented Jun 4, 2020

@rikkit yes, go for it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants