improve error messages for .toBeInTheDocument #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnapse
approved these changes
Oct 7, 2019
|
@kandros I'll be merging this soon. It totally slipped off my mind, sorry for the long delay. |
|
Not sure why the build here is taking forever. Invoking @testing-library/core-maintainers in case someone there can chime in on what went wrong. |
|
I'm not sure. I wouldn't worry about it. Just merge if you're happy with the changes :) |
|
🎉 This PR is included in version 4.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Improve error messages for
.toBeInTheDocumentWhy:
The current error was hard to understand
How:
Give more context in the error message
Checklist:
Before
.toBeInTheDocumentnot.toBeInTheDocumentAfter
.toBeInTheDocumentnot.toBeInTheDocument