Skip to content

Conversation

renatoagds
Copy link
Contributor

The current toBeInTheDocument examples isn't matching the proposed from @kentcdodds in Common Mistakes - https://kentcdodds.com/blog/common-mistakes-with-react-testing-library#using-query-variants-for-anything-except-checking-for-non-existence

Fixing this to help who's starting in the project.

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #287   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          315       315           
  Branches        72        72           
=========================================
  Hits           315       315           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd17d3...85c7f5e. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@gnapse gnapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gnapse gnapse merged commit 9b0510b into testing-library:master Aug 11, 2020
@gnapse
Copy link
Member

gnapse commented Aug 11, 2020

🎉 This PR is included in version 5.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@renatoagds renatoagds deleted the doc-to-be-in-document branch August 11, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants