docs(readme): Remove duplicate "data-testid" from example #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having two "data-testid" attributes is invalid, so I assume this is a typo/leftover. Removing should simplify example and prevent possible confusion.
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 315 315
Branches 72 72
=========================================
Hits 315 315 Continue to review full report at Codecov.
|
eps1lon
changed the title
|
@all-contributors add @danawoodman for docs |
|
I've put up a pull request to add @danawoodman! 🎉 |
|
🎉 This PR is included in version 5.11.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove duplicate "data-testid" in the readme.
Why:
Having two "data-testid" attributes is invalid, so I assume this is a typo/leftover. Removing should simplify example and prevent possible confusion.
How:
Self explanatory 😆
Checklist: