fix: Updated toBeInTheDocument test #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toBeInTheDocument was using the wrong selector like the README. Resetting it to check on the actual svg element.
smacpherson64
changed the title
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 113 113
Branches 24 24
=====================================
Hits 113 113Continue to review full report at Codecov.
|
gnapse
approved these changes
Jul 24, 2018
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The toBeInTheDocument was using the wrong selector like the README. Resetting it to check on the actual svg element.
Why:
This part of the test is not is not actually checking what it was intended to check.
How:
Updated the selector to use
svg-elementinstead ofhtml-elementChecklist: