Skip to content

Conversation

smacpherson64
Copy link
Collaborator

@smacpherson64 smacpherson64 commented Aug 1, 2018

What:
Implemented fix from @jgoz to failing TI builds. See the following for more details:
#47 (comment)

Why:
The Travis builds are currently failing.

How:
Implemented fix from @jgoz and added a testURL into the jest.config

Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged
  • Added myself to contributors table N/A

Implemented fix from @jgoz to failing TI builds:

#47 (comment)
@codecov-io
Copy link

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #48   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines         119    119           
  Branches       25     25           
=====================================
  Hits          119    119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df7560...40c9349. Read the comment docs.

@gnapse
Copy link
Member

gnapse commented Aug 1, 2018

This is weird, but ok, good that @jgoz figured it out. Is this ready to be merged? Is this what has #47 build failing?

@jgoz
Copy link
Collaborator

jgoz commented Aug 1, 2018

@gnapse Yes, it's related to a jsdom upgrade: jestjs/jest#6766

@gnapse gnapse merged commit 3f351eb into master Aug 1, 2018
@gnapse gnapse deleted the pr/add-testurl-to-jest-config branch August 1, 2018 22:55
@gnapse
Copy link
Member

gnapse commented Aug 3, 2018

🎉 This PR is included in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants