Skip to content

Conversation

smacpherson64
Copy link
Collaborator

@smacpherson64 smacpherson64 commented Aug 4, 2018

What:
Updated README matcher examples to be more consistent
Updated README matcher intro with note about jest-dom varied usage
Organized README matcher examples in alphabetical order

Why:
To improve and create a consistent experience with matcher examples

How:
Updated the README examples to be similar to the discussion in #50

Checklist:

  • Documentation
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged N/A
  • Added myself to contributors table N/A

Closes #50

@smacpherson64 smacpherson64 requested review from gnapse and jgoz August 4, 2018 23:53
Copy link
Member

@gnapse gnapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thanks!

@gnapse gnapse merged commit 9c3ea4e into testing-library:master Aug 14, 2018
@smacpherson64 smacpherson64 deleted the pr/update-readme-examples branch August 14, 2018 14:12
@gnapse
Copy link
Member

gnapse commented Sep 18, 2018

🎉 This PR is included in version 1.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants