Include file extension in generated import specifiers #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This outputs imports like
import { pure } from "./pure.mjs"
Why:
This change should fix vitest-dev/vitest#1375.
ES Module specifiers are URLs with no implied extension or index file resolution. Tools like Vite relax this to allow CommonJS-style
./index.js
resolution, but it's better to avoid relying on this since it's unspecified behavior.How:
This uses the
--out-file-extension
option that was added to@babel/cli
in version 7.8.0. It allows specifying a filename extension to use for generated import specifiers.Checklist: