Skip to content

small typo fix #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2019
Merged

small typo fix #109

merged 1 commit into from
Jun 25, 2019

Conversation

iqbal125
Copy link
Contributor

changed "ofter" to often

What:

Why:

How:

Checklist:

  • Documentation updated
  • Tests
  • Typescript definitions updated
  • Ready to be merged
  • Added myself to contributors table

changed "ofter" to often
@codecov-io
Copy link

codecov-io commented Jun 24, 2019

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          39     39           
  Branches        3      3           
=====================================
  Hits           39     39

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3701efb...0062202. Read the comment docs.

@@ -9,7 +9,7 @@ route: '/usage/advanced-hooks'
## Context

Often, a hook is going to need a value out of context. The `useContext` hook is really good for
this, but it will ofter required a `Provider` to be wrapped around the component using the hook. We
this, but it will often required a `Provider` to be wrapped around the component using the hook. We
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also dont think the d in required is correct either

but it will often require a Provider

@mpeyper
Copy link
Member

mpeyper commented Jun 25, 2019

Thanks for this. I'll merge this one and if you (or anyone else) want to raise one for the other typo I spotted above, it would be much appreciated.

@mpeyper mpeyper merged commit ebf8460 into testing-library:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants