Refactor tests to reduce duplication for different renderers #643
Conversation
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 235 235
Branches 29 33 +4
=========================================
Hits 235 235 Continue to review full report at Codecov.
|
| @@ -0,0 +1,258 @@ | |||
| import { useState, useRef, useEffect } from 'react' | |||
|
|
|||
| describe('async hook tests', () => { | |||
There was a problem hiding this comment.
I wouldn't mind having another go at this test file sometime (not in this change). Currently, it the longest running test by far, clocking almost 20s on my macbook to run all the tests for all the renderers. We had problems in the past making the delays too small, but that was before the refactoring of the asyncUtils which I think has made things more reliable.
|
🎉 This PR is included in version 7.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Refactor tests to reduce duplication for different renderers.
Why:
Our test suite has lots of duplication, running the same (or almost the same) test against the
dom,nativeandserverrenderers.How:
Added a test utility that runs tests against groups of renderers.
Checklist:
For some reason, the current tests were not having
eslintwarnings appear. When moving them intosrc/__tests__/, the warnings appeared. This actually highlighted an issue with the type of thecleanupexport which is is anasyncfunction, but wasn't returning aPromisein the types. I've included updating them in this PR so we must remember to merge this as afixrather that thetestcommit.