Skip to content

Added - How to config custom render with CRA #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2018

Conversation

vctormb
Copy link
Contributor

@vctormb vctormb commented Nov 12, 2018

What:
Added an explanation on how to configure the custom render section on top of Create React App.

Why:
I tried to follow the config. used in the custom render section inside a CRA project, but it didn't work.

How:
I followed the recommendations from Dan: avoid relative paths in CRA

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

vctormb and others added 3 commits November 12, 2018 20:33
Added an explanation on how to configure the custom render section on top of Create React App.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks 👍

@kentcdodds kentcdodds merged commit d4f4b05 into testing-library:master Nov 13, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants