Skip to content

chore(ci): add cron job install script for smoke testing next #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

kentcdodds
Copy link
Member

What: Test react's next versions

Why: https://reactjs.org/blog/2019/10/22/react-release-channels.html#using-the-next-channel-for-integration-testing

How: added a step to the install in our .travis.yml which will upgrade react and react-dom to the next release if we're running the cron job.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

@kentcdodds
Copy link
Member Author

I tested this locally and it works well. I've configured travis to have a cron job run every day. We should be set with these changes :)

@kentcdodds
Copy link
Member Author

Oh, and adding the cron job was really quick and painless. Used the docs here:

https://docs.travis-ci.com/user/cron-jobs

And here's what it looks like:

travis cron job showing it will run on master daily

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

Merging #505 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #505   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          95     95           
  Branches       15     15           
=====================================
  Hits           95     95

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d11b0...23f7e29. Read the comment docs.

@kentcdodds kentcdodds merged commit 10a515e into master Oct 23, 2019
@kentcdodds kentcdodds deleted the pr/add-cron branch October 23, 2019 17:08
# as requested by the React team :)
# https://reactjs.org/blog/2019/10/22/react-release-channels.html#using-the-next-channel-for-integration-testing
- if [ "$TRAVIS_EVENT_TYPE" = "cron" ]; then npm install react@next
react-dom@next; fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Somehow this ended up on two lines 🙃 Maybe it'll work anyway, but I'll fix that. Should be on one line.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can manually add a \ at the end of line to signify multi-line statements.

Going to assume your prettier messed it up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier doesn't typically introduce bugs. I just ran it locally and checked and prettier didn't touch this line. I'm pretty sure this happened because I just used vim and probably hit a key by mistake.

@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 9.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants