Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): separate basic example code block #703

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

michael-siek
Copy link
Contributor

@michael-siek michael-siek commented Jun 8, 2020

What: Fix the documentation in the README.md file to separate the basic example code block

Why: OCD/keep with uniformity with how the other example code blocks are structured

How:

Checklist:

  • Documentation added to the
    docs site
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85c99d0:

Sandbox Source
fervent-maxwell-vv9ek Configuration
zealous-kowalevski-35p9b Configuration

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #703 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #703   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          100       100           
  Branches        16        16           
=========================================
  Hits           100       100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c1de9...85c99d0. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. Thanks :)

@kentcdodds kentcdodds merged commit 9c7f948 into testing-library:master Jun 8, 2020
@kentcdodds
Copy link
Member

@all-contributors please add @michael-siek for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @michael-siek! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants