Skip to content

fix: Trigger ongot-/onlostpointercapture when calling got-/lostpointercapture #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 13, 2020
Merged

fix: Trigger ongot-/onlostpointercapture when calling got-/lostpointercapture #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6722ab
test: Add full PointerEvent test suite
eps1lon Sep 13, 2020
6bcb456
Confirmed DTL issue
eps1lon Sep 13, 2020
00c8e55
Use actual interface
eps1lon Sep 13, 2020
0fa95eb
Merge remote-tracking branch 'upstream/master' into test/pointer-events
eps1lon Sep 13, 2020
138e1ef
bump dtl
eps1lon Sep 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.11.2",
"@testing-library/dom": "^7.23.0"
"@testing-library/dom": "^7.24.2"
},
"devDependencies": {
"@testing-library/jest-dom": "^5.11.4",
Expand Down
36 changes: 16 additions & 20 deletions src/__tests__/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,22 @@ const eventTypes = [
],
elementType: 'button',
},
{
type: 'Pointer',
events: [
'pointerOver',
'pointerEnter',
'pointerDown',
'pointerMove',
'pointerUp',
'pointerCancel',
'pointerOut',
'pointerLeave',
'gotPointerCapture',
'lostPointerCapture',
],
elementType: 'button',
},
{
type: 'Selection',
events: ['select'],
Expand Down Expand Up @@ -197,26 +213,6 @@ test('onChange works', () => {
expect(handleChange).toHaveBeenCalledTimes(1)
})

test('calling `onPointerEnter` directly works too', () => {
const handlePointerEnter = jest.fn()
const handlePointerLeave = jest.fn()
const {container} = render(
<div>
<button
onPointerEnter={handlePointerEnter}
onPointerLeave={handlePointerLeave}
/>
</div>,
)
const button = container.firstChild.firstChild

fireEvent.pointerEnter(button)
expect(handlePointerEnter).toHaveBeenCalledTimes(1)

fireEvent.pointerLeave(button)
expect(handlePointerLeave).toHaveBeenCalledTimes(1)
})

test('calling `fireEvent` directly works too', () => {
const handleEvent = jest.fn()
const {
Expand Down