Skip to content

#10 - clean up document targets and components #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2019
Merged

#10 - clean up document targets and components #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d66386
clean up document targets and components
oieduardorabelo May 4, 2019
54fd79d
jest cache was returning `<div></div>`, running with `--no-cache` fix…
oieduardorabelo May 4, 2019
b48d507
we can safely ignore `else` for code coverage here - https://github.c…
oieduardorabelo May 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const render = (Component, {target = document.createElement('div'), ...op
target,
})

mountedContainers.add(component)
mountedContainers.add({target, component})
return {
component,
// eslint-disable-next-line no-console
Expand All @@ -20,7 +20,12 @@ export const render = (Component, {target = document.createElement('div'), ...op
}

const cleanupAtContainer = container => {
container.$destroy()
const {target, component} = container
component.$destroy()
/* istanbul ignore else */
if (target.parentNode === document.body) {
document.body.removeChild(target)
}
mountedContainers.delete(container)
}

Expand Down
8 changes: 8 additions & 0 deletions tests/render.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,17 @@ describe('render', () => {
})

test('debug', () => {
const originalConsole = global.console

global.console = {log: jest.fn()}

const {debug} = render(App)

debug()

expect(global.console.log).toHaveBeenCalledWith(prettyDOM(document.body))

global.console = originalConsole
})

test('custom container target', () => {
Expand All @@ -61,4 +65,8 @@ describe('render', () => {
expect(getByText('Hello world!')).toBeInTheDocument()
expect(getByTestId('custom-target')).toBeInTheDocument()
})

test('after each test above, document is clean from targets and components', () => {
expect(document.body.innerHTML).toBe('')
})
})