Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unnecessary tests and skips #338

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

mcous
Copy link
Collaborator

@mcous mcous commented Mar 16, 2024

Overview

This PR follows up the option cleanup of #325 with some test cleanup.

Change log

  • Remove an unnecessary cleanup test skip
  • Remove a redundant fireEvent test
  • Ensure IS_SVELTE_5 from util is used in tests
  • Align console mocks for consistency
  • Replace new Promise for sleep with node:timers/promises
  • Sort imports in tests when my editor yelled at me

@mcous mcous force-pushed the test-cleanup branch 3 times, most recently from 21cd691 to bb67a3e Compare March 16, 2024 18:23
@yanick
Copy link
Collaborator

yanick commented Mar 17, 2024

#325 is merged. This one should be rebasable without any conflict.

@mcous mcous marked this pull request as ready for review March 17, 2024 15:38
@mcous
Copy link
Collaborator Author

mcous commented Mar 25, 2024

@yanick rebased and ready for re-review

@yanick yanick merged commit 16f6b40 into testing-library:next Mar 25, 2024
17 checks passed
Copy link

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants