Update all references to `cleanup-after-each` for React

[kentcdodds]

This file no longer exists and any reference to it should be removed.

Also, we should probably document the automatic behavior and how to avoid/disable it.

[jacobrask]

Hm, why was it removed? No longer needed?

[kentcdodds]

Correct. As of v9.0.0 it's automatic: https://github.com/testing-library/react-testing-library/releases/tag/v9.0.0

[dustinmyers]

Also, we should probably document the automatic behavior and how to avoid/disable it.

What are the use cases for disabling auto cleanup?

[kentcdodds]

Great question @dustinmyers. There are no good use cases for disabling auto-cleanup, but some people prefer to write their tests like this (taken from https://kentcdodds.com/blog/test-isolation-with-react):

import '@testing-library/jest-dom/extend-expect'
import React from 'react'
import {render, fireEvent} from '@testing-library/react'
import {Counter} from '../counter'

const {getByText} = render(<Counter maxClicks={4} initialCount={3} />)
const counterButton = getByText(/^count/i)

test('the counter is initialized to the initialCount', () => {
  expect(counterButton).toHaveTextContent('3')
})

test('when clicked, the counter increments the click', () => {
  fireEvent.click(counterButton)
  expect(counterButton).toHaveTextContent('4')
})

test(`the counter button is disabled when it's hit the maxClicks`, () => {
  fireEvent.click(counterButton)
  expect(counterButton).toHaveAttribute('disabled')
})

test(`the counter button does not increment the count when clicked when it's hit the maxClicks`, () => {
  expect(counterButton).toHaveTextContent('4')
})

test(`the reset button has been rendered and resets the count when it's hit the maxClicks`, () => {
  fireEvent.click(getByText(/reset/i))
  expect(counterButton).toHaveTextContent('3')
})

It's poor testing practice, but it is something people like to do, and because having a workaround is pretty simple, having and documenting that workaround is necessary.

[dustinmyers]

Do instances of afterEach(cleanup) also need to be removed from the documentation? Or just references to the cleanup-after-each file?

[kentcdodds]

Yeah, those need to be removed from the docs as well.

It's not technically deprecated (you wont get any deprecation message for it), and it wont break anything (basically nothing will happen), but yeah, there's no reason for it now.

[afontcu]

Closing thanks to #213

(feel free to open a new issue/PR if we missed any reference to RTL's cleanup()!)