-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(svelte-testing-library): add event, slot, binding, context examples #1366
docs(svelte-testing-library): add event, slot, binding, context examples #1366
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Not related to the PR, but I think it could also be useful to show how to "register" the jest-dom matchers so they can be used with Vitest.
Thanks for the review @timdeschryver! Will incorporate those suggestions.
Those instructions are covered in the setup docs, updated in #1360. Do you think there needs to be an additional callout and/or additional information?
|
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
@mcous oops I missed that. |
@yanick if you got a sec, I could use your eyes on this one, too, to close out a big chunk of our backlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
Overview
We've got a few tickets over in svelte-testing-library asking for how to test certain things. This PR adds examples for all the open requests:
I've tested these examples and they all seem to be working, but I'm not the world's best speller nor typist, so any help catching typos is very much appreciated!
Change log
on:xyz
and function props