Skip to content

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 21, 2019

@eps1lon
Copy link
Member Author

eps1lon commented Sep 24, 2019

I missed mentioning this in the original PR. Could anybody from @testing-library/dom take a look if the wording is ok?

Copy link
Collaborator

@alexkrolick alexkrolick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an example of when an element would be excluded by default and included by hidden: true?

@eps1lon
Copy link
Member Author

eps1lon commented Sep 24, 2019

Can you add an example of when an element would be excluded by default and included by hidden: true?

Good idea. Added a more common example with modals and aria-hidden

@alexkrolick alexkrolick merged commit 96b436f into testing-library:master Sep 24, 2019
@alexkrolick
Copy link
Collaborator

💯

@eps1lon eps1lon deleted the feat/role-hidden branch September 24, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants