-
Notifications
You must be signed in to change notification settings - Fork 726
docs: fix broken links #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix broken links #680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I wish adding the .mdx
extension wasn't necessary. The file extension of the source markup doesn't affect the link for the compiled site :/
But it's important to get these broken links fixed, so I am OK with merging
I definitely agree, maybe we can take it up with docusaurus people.. |
Yeah, let's open an issue about the extension in links on the docusaurus side |
@alexkrolick looks like in the docs they never claim that omitting the file extension will work, I probably found it redundant because it worked on localhost: Do you think we should maybe open a feature request for that? Since they never said it's supported I guess it's not a bug.. |
It works without the extension because the links pass through the markdown parser as-is, and the folder structure of the docs matches the output directory structure, so relative links remain the same |
Sorry but I'm not sure I 100% understand what we want from docusaurus then. |
This is now ready for review.
I added mdx suffix to missing files, removed the relative paths since they aren't needed and also added some titles to a few snippets I saw :)