docs: add TypeScript example for custom-queries.js #893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickserv
changed the title
MatanBobi
approved these changes
Jul 21, 2021
docs/react-testing-library/setup.mdx
Outdated
| @@ -155,6 +155,11 @@ elements by `data-cy`, a "test ID" convention mentioned in the | |||
| [Cypress.io](https://docs.cypress.io/guides/references/best-practices.html#Selecting-Elements) | |||
| documentation. | |||
|
|
|||
| <Tabs groupId="test-utils" defaultValue="js" values={[ {label: 'Javascript', | |||
| value: 'js'}, {label: 'Typescript', value: 'ts'}, ]}> | |||
There was a problem hiding this comment.
[Nit]
Maybe we should write Javascript and Typescript with a capital s?
(Not sure we're following this rule in other places also, so this really isn't important)
|
@nickmccurdy Can we merge this? :) |
eps1lon
reviewed
Aug 9, 2022
Use language branding
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #889