Skip to content

chore: Format docs with prettier #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 22, 2021

Ran npm run format-docs

@@ -13,7 +13,7 @@ npm install --save-dev @testing-library/jest-native
```

```javascript
<View>
;<View>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-semi 🤡

That section can be improved anyway so I'll handle it in a follow-up

@eps1lon eps1lon merged commit 672b1ef into testing-library:main Oct 22, 2021
@eps1lon eps1lon deleted the chore/format branch October 22, 2021 08:54
@MatanBobi
Copy link
Member

I remember that last time we ran this, it caused some issues with the tab items in pages with tabs, did you get a chance to verify that they didn't break?

@eps1lon
Copy link
Member Author

eps1lon commented Oct 22, 2021

I remember that last time we ran this, it caused some issues with the tab items in pages with tabs, did you get a chance to verify that they didn't break?

I was not aware of such an issue. If that's the case then we should disable formatting.

@MatanBobi
Copy link
Member

I was not aware of such an issue. If that's the case then we should disable formatting.

I'm not sure if we resolved it or not. It will be better to check, if any of the pages broke, let me check it..

@MatanBobi
Copy link
Member

@eps1lon I looked at the preview of this PR and the code and things look ok, sorry for the false alarm :)

@eps1lon
Copy link
Member Author

eps1lon commented Oct 22, 2021

@eps1lon I looked at the preview of this PR and the code and things look ok, sorry for the false alarm :)

Do you maybe have a pointer to a commit that broke pages? Would be nice to figure this out so that we don't have to manually review formatting changes.

@MatanBobi
Copy link
Member

I think it was already resolved, the reason was that we used markdown parser instead of mdx and I fixed it here
I guess I missed the fact that the parser can be inferred from the file path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants