Skip to content

fix: Use relative links for internal links #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

fix: Use relative links for internal links #961

merged 1 commit into from
Oct 25, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 25, 2021

Last 404 was to /docs/dom-testing-library. Found by listing all internal links using https://gist.github.com/eps1lon/29e4c57c546a4aef4701913e0237b831

Closes #960

@eps1lon eps1lon marked this pull request as ready for review October 25, 2021 12:50
MatanBobi
MatanBobi approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@alexkrolick alexkrolick merged commit 4cecc47 into testing-library:main Oct 25, 2021
@eps1lon eps1lon deleted the fix/404s branch October 25, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatanBobi MatanBobi MatanBobi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Many links broken on api documentation
3 participants
@eps1lon @MatanBobi @alexkrolick