feat: add support for custom test-id attributes #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Follow-up on #227,
the custom test-id is now supported in both the (chrome) devtool, as well as the web version.
the settings dialog has been updated to share components with the web version (as prepared in feat: update layout, add settings menu and group links #226).
settings are now persistent across browser session
Why:
To have a single uniform experience across extension and web version.
How:
update
usePlaygroundto manage settingsstore settings to localStorage on change, and load them on page load.
share components between web version & extension
Checklist: