Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct oembed iframe src #283

Merged
merged 1 commit into from
Oct 29, 2020
Merged

fix: correct oembed iframe src #283

merged 1 commit into from
Oct 29, 2020

Conversation

MichaelDeBoey
Copy link
Member

Just like you have at

testing-playground/src/components/Embed.js

Line 37 in dc14e4a

const embedCode = `<iframe src="${embedUrl}" height="${height}" width="100%" scrolling="no" frameBorder="0" allowTransparency="true" title="Testing Playground" style="overflow: hidden; display: block; width: 100%"></iframe>`;

smeijer
smeijer approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@smeijer smeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looking good.

@smeijer smeijer merged commit 4e8973c into testing-library:develop Oct 29, 2020
@MichaelDeBoey MichaelDeBoey deleted the update-oembed-iframe branch October 29, 2020 20:06
@smeijer smeijer changed the title fix(oEmbed): Bring iframe in line with the embed in the GUI fix: correct oembed iframe src Oct 30, 2020
@smeijer smeijer mentioned this pull request Oct 30, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeijer smeijer smeijer approved these changes

Assignees

@MichaelDeBoey MichaelDeBoey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelDeBoey @smeijer