Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore change detection in query pane #318

Merged
merged 1 commit into from
Dec 8, 2020
Merged

fix: restore change detection in query pane #318

merged 1 commit into from
Dec 8, 2020

Conversation

delca85
Copy link
Member

@delca85 delca85 commented Dec 7, 2020

What:

Playground now passes state and dispatch to PlaygroundPanels and PlaygroundPanels does not call any more usePlayground hook to retrieve these two values.

Why:

This fixes #314 introduced by #296.

How:

Checklist:

  • Tests
  • Ready to be merged

aganglada
aganglada approved these changes Dec 8, 2020
View reviewed changes
Copy link
Collaborator

@aganglada aganglada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smeijer smeijer changed the title pass state and dispatch to PlaygroundPanels to fix update query output fix: restore change detection in query pane Dec 8, 2020
@smeijer smeijer merged commit 7fe4f2c into develop Dec 8, 2020
@smeijer smeijer deleted the issue-314-fix-query-result branch December 8, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aganglada aganglada aganglada approved these changes

Assignees

@delca85 delca85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query input/output non-functional
3 participants
@delca85 @aganglada @smeijer