Bound queries to the base element #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afontcu
commented
Sep 30, 2019
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 66 67 +1
Branches 11 13 +2
=====================================
+ Hits 66 67 +1
Continue to review full report at Codecov.
|
afontcu
force-pushed
the
bound-queries-body
branch
from
38ebd3d
to
d20089c
Compare
|
All looks good to me, I think the resulting code is a lot cleaner as well. |
dfcook
approved these changes
Sep 30, 2019
|
@ChristophWalter @dfcook I've updated the PR in order to make it closer to React Testing Library. https://testing-library.com/docs/react-testing-library/api#container |
dfcook
approved these changes
Oct 9, 2019
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix several issues when trying to query content outside of the regular DOM node tree (portals, modals, etc). It tries to mirror React Testing Library behavior.
I also added a test based on Vuetify, because (1) it is related to the introduced changes and (2) Vuetify is widely-used and comes with its own nuances.
This is a breaking change since
containerandbaseElementchanged their meaning.This PR closes #98