Skip to content
This repository was archived by the owner on Sep 12, 2024. It is now read-only.
This repository was archived by the owner on Sep 12, 2024. It is now read-only.

Better async implementation #10

@osolmaz

Description

@osolmaz

Feedback from Eden:

Oddly you're not using async where it makes sense - in the network requests - but I'm guessing you're forced into it for Jupyter. It's not essential unless you ever find yourself in a place with multiple user requests for code gen.

What would be interesting, and would use that async appropriately, is sending the request to multiple services and letting the user pick the most appropriate one.

IPythonKernel.do_execute() is currently overloaded in a hacky way and it poses problems e.g. when KeyboardInterrupt is called. Async handling needs to be overall improved.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions