-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): adds external context dep #151
Conversation
Signed-off-by: andrew <andrew@textile.io>
okay, first error
The actual error coming back is 'Thread not found'. which is strange since you'd think auth would come before exists |
The second issue
is erroring out because it's not throwing an error when the token doesn't exist |
Hmmm, so now that Context is mutable, its possible that we are properly authenticated, and it needs to be cleared out? |
Okay, same errors with 3 and 4. will try to scope the context a bit more |
what do you make of error 1 though? |
taking a look now |
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
The issue was indeed that the Context was being mutated underneath us due to the fact that it is now mutable. The mutable API is easier to hide, but harder to deal with. Its a trade off I guess? Anyway, I have also tried to reduce the number of times we actually reference the context in the tests to hopefully test how well we can 'hide' it. Also, this unexpected mutation is really only an issue for tests, where we want to throw errors etc. |
No description provided.