This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Node fixes #160
Merged
Node fixes #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Ok I think this is g2g. Will tackle native module testing in a new PR. |
sanderpick
approved these changes
Jun 25, 2018
| @@ -220,6 +203,7 @@ export function * pairNewDevice (action) { | |||
|
|
|||
| export function * shareImage ({thread, hash, caption}) { | |||
| try { | |||
| // TODO: sharePhoto returns a String. Should we be using it? | |||
There was a problem hiding this comment.
the return string here is the newly created block id, we can remove that at some point because it doesn't seem useful since you just request all photos again
| @@ -272,8 +277,7 @@ public void getFileData (String id, String path, Promise promise) { | |||
| @ReactMethod | |||
| public void pairDevice (String pkb64, Promise promise) { | |||
| try { | |||
| node.pairDevice(pkb64); | |||
| promise.resolve(true); | |||
| promise.resolve(node.pairDevice(pkb64)); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleaning up how we interact with the JS node API, fixing a couple bugs. Started down the path of adding tests for the native layer node modules, but it's harder than I thought, will tackle it in another PR.