This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
making the radio button a touch target for the thread select screen #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for the PR @saranrapjs! Looking at the code now, I think there's a (more) simple fix. Will insert a couple comments. |
asutula
reviewed
Dec 5, 2018
| { selected && <Image style={styles.buttonImage} source={require('./statics/check.png')} /> } | ||
| { selected && <View style={[styles.buttonSelected, disabled && styles.buttonDisabled]} /> } | ||
| </TouchableOpacity> | ||
| ) | ||
| } | ||
|
|
||
| RadioButton.defaultProps = { |
There was a problem hiding this comment.
First, this component is just a simple stateless component. It's a function that takes in props and return a component. Setting defaultProps has no effect I think.
There was a problem hiding this comment.
Stateless components are no different from class components: they will pull in static properties like defaultProps/propTypes in the same way. I wasn't exactly sure where all else this radio button was being used, & had wanted to have a default in case!
asutula
reviewed
Dec 5, 2018
asutula
reviewed
Dec 5, 2018
asutula
reviewed
Dec 5, 2018
asutula
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
textile is great! i've honestly waiting for something like this to bubble up and am excited to see how usable it is even for not p2p heads like me :)
this PR fixes something i ran into when initially poking around in the app, where tapping on the radio button in the "Thread select" view for an image wouldn't select the corresponding thread. hopefully uncontroversial, but let me know if there's anything i should do differently