Skip to content

Nested objects are now allowed for translations. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2016
Merged

Nested objects are now allowed for translations. #6

merged 2 commits into from
Dec 23, 2016

Conversation

BorntraegerMarc
Copy link
Contributor

Resolves #4

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.877% when pulling b4128ce on BorntraegerMarc:feature/nested-objects into ad01588 on tflori:master.

tflori
tflori reviewed Dec 23, 2016
View reviewed changes
Copy link
Owner

@tflori tflori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please run ts lint: npm run tslint and fix the errors

angular2-translator/TranslateLoaderJson.ts Outdated

private filter(translations): any {
for (let key in translations) {
if (typeof translations[key] == "object" && translations[key] !== null && !Array.isArray(translations[key])) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is too long

angular2-translator/TranslateLoaderJson.ts Outdated

private filter(translations): any {
for (let key in translations) {
if (typeof translations[key] == "object" && translations[key] !== null && !Array.isArray(translations[key])) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== should be ===

@tflori
Copy link
Owner

tflori commented Dec 23, 2016

It's another interesting approach but have you tried accessing them? because I think that TranslateLoader::instant('app.loginText') can not access this objects.

But I like your tests (except the things tslint mentioned).

@BorntraegerMarc
Copy link
Contributor Author

@tflori yup, I'm fixing them now

@BorntraegerMarc
Copy link
Contributor Author

OK, I'm merging your logic and my tests together 😄

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.872% when pulling ac18d24 on BorntraegerMarc:feature/nested-objects into ad01588 on tflori:master.

@BorntraegerMarc
Copy link
Contributor Author

BorntraegerMarc commented Dec 23, 2016 •
edited
Loading

OK @tflori Everything is included now. Inclusive tests... Could you merge the PR and publish a new version? That would be charmin' 😄

@tflori tflori merged commit 3b3bcb3 into tflori:master Dec 23, 2016
@tflori tflori mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tflori tflori tflori left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BorntraegerMarc @coveralls @tflori