Skip to content

add nested translations #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

add nested translations #5

wants to merge 3 commits into from

Conversation

tflori
Copy link
Owner

@tflori tflori commented Dec 23, 2016

This will solve #4

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 97.674% when pulling 785d15d on feature-nested-translations into ad01588 on master.

@tflori
disable the hasOwnProperty check
2af8397 
This will never happen for json objects and therefore it is hard to mock.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.877% when pulling 2af8397 on feature-nested-translations into ad01588 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.877% when pulling 0ec33da on feature-nested-translations into ad01588 on master.

@tflori tflori mentioned this pull request Dec 23, 2016
Closed
@tflori
Copy link
Owner Author

tflori commented Dec 23, 2016

duplicate from #6

@tflori tflori closed this Dec 23, 2016
@tflori tflori deleted the feature-nested-translations branch December 23, 2016 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tflori @coveralls