-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash 3.x compatibility #181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There're some errors from tests on macOS:
|
chenrui333
previously approved these changes
May 1, 2020
It looks like all the tests are fine now on default macOS bash |
|
ping @Zordrak |
Zordrak
reviewed
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate that this is necessary, but I appreciate the effort gone to in doing it.
Zordrak
approved these changes
May 26, 2020
Thanks @Zordrak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default bash installed on macOS is 3.2.57.
And there are some difference in brace expansion for
@
for bash 3.x and 5.x:I suggest to replace
${@}
with$@
to make tfenv 2 compatible with default bash on macOS:I ran
shellcheck
against my changes and it suggested to replace$@
to$*
for printing logs, since it was mixing string variables and arrays (https://github.com/koalaman/shellcheck/wiki/SC2145).All the tests have passed on bash 3.x locally on my mac.
My bash knowledge quite limited, so I'm not aware of the potential drawbacks for this solution.
Closes #180