-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the Accounting Console to the game (HOP Job Content) #66304
Conversation
Can you display the pay modifier as a percentage on the console? |
I'm not too big a fan of turning the HoP into an off brand detective and perhaps boil down to hunting valids. |
could this not be an NTOS app? |
It isn't though, it's a standalone computer console, unless you're suggesting it become one instead? |
|
could be cool to make it one, yeah |
As a HoP main, this seems pretty cool; I'm just kind of struggling to see a purpose for it beyond the HoP validhunting. There just isn't much of a need to track purchases unless if you're trying to find a criminal or antag. Even though it doesn't track money income, maybe it could also have some way to change people's pay modifiers? If someone isn't doing their job, maybe you can dock their pay a little bit. If someone is doing a great job, maybe you can increase their pay modifier or give them some sort of bonus. Features would probably need to be timelocked in some way to prevent just increasing everyone's pay to the moon, but at least it would give the machine more purpose besides doing something that feels like it fit more with security. |
I'm holding off on anything that would change the pay modifier because the other economy PR (Linked in the PR body) is moving back to passive income, and I don't want the ability to change the value of paychecks before we... have regular paychecks back. That should probably be consolidated once this and that PR are both in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix conflicts
* tgui input hotfix tgstation/tgstation#64698 * changes how tgui handles static data tgstation/tgstation#64757 * tgstation/tgstation#64885 * tgstation/tgstation#65008 * cooldown check * read preferences doenst exist here * tgstation/tgstation#65378 * Adds support for embedding react components in tgui chat * tgstation/tgstation#65686 * tgstation/tgstation#65943 * previous part 2 * oops forgot * tgstation/tgstation#66220 * tgstation/tgstation#66299 * FUCk forgot 1 * tgstation/tgstation#59914 * tgstation/tgstation#66304 * tgstation/tgstation#66309 * tgstation/tgstation#66317 * tgstation/tgstation#66691 * tgstation/tgstation#66757 * small changes from 66933 * tgstation/tgstation#67137 * tgui part of tgstation/tgstation#67691 and tgstation/tgstation#66971 * forgot public html * tgstation/tgstation#67935 prewritepackages * after write packages * tgstation/tgstation#67937 * oops * tgstation/tgstation#68216 * tgstation/tgstation#68356 * tgstation/tgstation#68679 * tgstation/tgstation#68887 * prettier ignore outside * tgstation/tgstation#69219 * tgstation/tgstation#69459 * tgstation/tgstation#69527 * tgstation/tgstation#69735 * tgstation/tgstation#69786 * tgstation/tgstation#70779 * boop * Update code/modules/mob/living/silicon/ai/examine.dm * fix ? * io * yo * prettier * prettier + other stuff + tgui say etc * okay ? * webpack tguisay * ntoswindow * tguialert move * tgui say work ? * tgstation/tgstation#71037 * rollback tguisay * comment out tgui say * remove tguisay dm files * updates tgui folder * whytflinter * rerun * fixes stack trace on fullupdate * woops, removes \n from join() * balloon alert * timeleft shenanigan solve stack_trace * check if fix linter * add it back * woo linter
About The Pull Request
This PR adds the accounting console to the game, as a console that exists round start within the HOP's office. The accounting console allows for players to get 2 separate lists of information:
[person] spent [cost]CR on [Purchase Source]
. It's intentionally left without all the information so that players will need to investigate if they notice strange purchases coming from an account, as a kind of ghetto money forensics.If the economy is being crashed by the Crab17 or the market crash, the console is disabled for the duration to prevent the owner of the crab from being outed instantly.
Money incomes are not tracked on the machine, but purchases/spending is, either from vending or from cargo.
In addition, the circuit board has been added to the techweb under the computerized recordkeeping node.
The code from the blinking aspect I got from goof, but see below for more context.
Why It's Good For The Game
I've been meaning to add something similar to this for awhile now, but in the interim with the major economy PR in review I thought it'd make for a good companion PR to #65795. Between in-game forensics as well as the code existing for admins to check player interactions with economy systems, this might drive more interesting player interactions.
Plus, by giving this to the HOP, it gives him an interaction with the economy gameplay loop, as he can effectively act like the station accountant when money or spending needs to be tracked on the station. Hopefully this sort of thing will become more interesting as accessibility and integration improves across the codebase.
Also this is so minor I'm not labeled this as a tweak but there was a minor logging issue that I fixed where things were calling the wrong parent in economy logging here.
Changelog
🆑
add: The accounting console has been added to the HOP's office, allowing them to track purchases, and bank balances of the crew on station. It's not illegal, it's the competitive advantage!
/:cl: