Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgui: Fix usage of computeBoxClassName #66691

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

stylemistake
Copy link
Member

@stylemistake stylemistake commented May 4, 2022

About The Pull Request

It's a dumb error that I have sneaked into the code and it was unnoticed for god knows how long. If it was TypeScript, it'd be found before it was committed.

Yes, it's a web edit.

Why It's Good For The Game

Fixes Box-like behavior on Layout tgui component, makes it more consistent. Makes certain properties, like color, that we unusable before, now usable.

@tgstation-server tgstation-server added the UI We make the game less playable, but with round edges label May 4, 2022
@stylemistake stylemistake added Fix Rewrites a bug so it appears in different circumstances Verified ✔️ Yeah, i'm a coder. What about it? labels May 4, 2022
@Mothblocks Mothblocks merged commit 4d9a382 into master May 6, 2022
@Mothblocks Mothblocks deleted the stylemistake-patch-1 branch May 6, 2022 04:51
github-actions bot added a commit that referenced this pull request May 6, 2022
SplinterGP added a commit to SplinterGP/TerraGov-Marine-Corps that referenced this pull request Jul 1, 2022
TiviPlus pushed a commit to tgstation/TerraGov-Marine-Corps that referenced this pull request Nov 12, 2022
* tgui input hotfix tgstation/tgstation#64698

* changes how tgui handles static data tgstation/tgstation#64757

* tgstation/tgstation#64885

* tgstation/tgstation#65008

* cooldown check

* read preferences doenst exist here

* tgstation/tgstation#65378

* Adds support for embedding react components in tgui chat

* tgstation/tgstation#65686

* tgstation/tgstation#65943

* previous part 2

* oops forgot

* tgstation/tgstation#66220

* tgstation/tgstation#66299

* FUCk forgot 1

* tgstation/tgstation#59914

* tgstation/tgstation#66304

* tgstation/tgstation#66309

* tgstation/tgstation#66317

* tgstation/tgstation#66691

* tgstation/tgstation#66757

* small changes from 66933

* tgstation/tgstation#67137

* tgui part of tgstation/tgstation#67691 and tgstation/tgstation#66971

* forgot public html

* tgstation/tgstation#67935 prewritepackages

* after write packages

* tgstation/tgstation#67937

* oops

* tgstation/tgstation#68216

* tgstation/tgstation#68356

* tgstation/tgstation#68679

* tgstation/tgstation#68887

* prettier ignore outside

* tgstation/tgstation#69219

* tgstation/tgstation#69459

* tgstation/tgstation#69527

* tgstation/tgstation#69735

* tgstation/tgstation#69786

* tgstation/tgstation#70779

* boop

* Update code/modules/mob/living/silicon/ai/examine.dm

* fix ?

* io

* yo

* prettier

* prettier + other stuff + tgui say etc

* okay ?

* webpack tguisay

* ntoswindow

* tguialert move

* tgui say work ?

* tgstation/tgstation#71037

* rollback tguisay

* comment out tgui say

* remove tguisay dm files

* updates tgui folder

* whytflinter

* rerun

* fixes stack trace on fullupdate

* woops, removes \n from join()

* balloon alert

* timeleft shenanigan solve stack_trace

* check if fix linter

* add it back

* woo linter
ZeWaka added a commit to goonstation/goonstation that referenced this pull request Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances UI We make the game less playable, but with round edges Verified ✔️ Yeah, i'm a coder. What about it?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants