-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleans up tgfont build command #69786
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stylemistake
approved these changes
Sep 8, 2022
Cool |
SplinterGP
added a commit
to SplinterGP/TerraGov-Marine-Corps
that referenced
this pull request
Nov 4, 2022
TiviPlus
pushed a commit
to tgstation/TerraGov-Marine-Corps
that referenced
this pull request
Nov 12, 2022
* tgui input hotfix tgstation/tgstation#64698 * changes how tgui handles static data tgstation/tgstation#64757 * tgstation/tgstation#64885 * tgstation/tgstation#65008 * cooldown check * read preferences doenst exist here * tgstation/tgstation#65378 * Adds support for embedding react components in tgui chat * tgstation/tgstation#65686 * tgstation/tgstation#65943 * previous part 2 * oops forgot * tgstation/tgstation#66220 * tgstation/tgstation#66299 * FUCk forgot 1 * tgstation/tgstation#59914 * tgstation/tgstation#66304 * tgstation/tgstation#66309 * tgstation/tgstation#66317 * tgstation/tgstation#66691 * tgstation/tgstation#66757 * small changes from 66933 * tgstation/tgstation#67137 * tgui part of tgstation/tgstation#67691 and tgstation/tgstation#66971 * forgot public html * tgstation/tgstation#67935 prewritepackages * after write packages * tgstation/tgstation#67937 * oops * tgstation/tgstation#68216 * tgstation/tgstation#68356 * tgstation/tgstation#68679 * tgstation/tgstation#68887 * prettier ignore outside * tgstation/tgstation#69219 * tgstation/tgstation#69459 * tgstation/tgstation#69527 * tgstation/tgstation#69735 * tgstation/tgstation#69786 * tgstation/tgstation#70779 * boop * Update code/modules/mob/living/silicon/ai/examine.dm * fix ? * io * yo * prettier * prettier + other stuff + tgui say etc * okay ? * webpack tguisay * ntoswindow * tguialert move * tgui say work ? * tgstation/tgstation#71037 * rollback tguisay * comment out tgui say * remove tguisay dm files * updates tgui folder * whytflinter * rerun * fixes stack trace on fullupdate * woops, removes \n from join() * balloon alert * timeleft shenanigan solve stack_trace * check if fix linter * add it back * woo linter
github-merge-queue bot
pushed a commit
to cmss13-devs/cmss13
that referenced
this pull request
Feb 14, 2024
# About the pull request Ports tgstation/tgstation#71808 and tgstation/tgstation#69786 from TG. The first PR fixes an issue where some changelog icons (specifically those for `soundadd`, `sounddel`, `imageadd`, and `imagedel`) appeared a lot smaller than others. (See images below) The second PR adds a VSCode task to rebuild tgfont and copy the result to `tgui\packages\tgfont\static` automatically, rather than having to run `yarn tgfont:build` and copy them there yourself. This task is already mentioned in [tgui\packages\tgfont\README_ICON_TUTORIAL.txt](https://github.com/cmss13-devs/cmss13/blob/41a39b96009f3d97206fd63416a2fb5a47c89525/tgui/packages/tgfont/README_ICON_TUTORIAL.txt#L7), so I'm guessing it was just missed when the rest was ported over. # Explain why it's good for the game Fixes a bug, and makes it easier to add new font icons in the future. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> **Before:** ![before](https://github.com/cmss13-devs/cmss13/assets/57483089/cdb85eeb-03a9-4768-863d-354f3599c3a1) **After:** ![after](https://github.com/cmss13-devs/cmss13/assets/57483089/9c360b58-818e-46cd-b2dd-ff764f53eb7b) </details> # Changelog :cl: fix: Fixed some changelog icons being smaller than others. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes tg-font build target copy the resulting css/font files to the static directory so you don't have to do this by hand.
Adds
tgui: rebuild tgfont
vscode taskNow you can just put your svg files in and run vscode task.