Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One source of introducing layers #49

Closed
2 tasks done
layik opened this issue Apr 26, 2021 · 0 comments · Fixed by #52
Closed
2 tasks done

One source of introducing layers #49

layik opened this issue Apr 26, 2021 · 0 comments · Fixed by #52

Comments

@layik
Copy link
Collaborator

layik commented Apr 26, 2021

In #38 we have a method to define DeckGL layer properties and use them either in generating layers or indeed in setting their values or assigning values from columns.

For this issue:

  • one source of truth where Layer is defined and used consistently throughout
  • define current set of layer props

For the latter, we can have:

  1. number (numeric)
  2. column (value from column), this is turned into a function on the fly
  3. colour (array) is used in DeckGL layers

This could do most of what eAtlas needs to do.

@layik layik changed the title One way of introducing layers One source of introducing layers Apr 26, 2021
@layik layik linked a pull request Apr 27, 2021 that will close this issue
Merged
layik added a commit that referenced this issue Apr 27, 2021
layik added a commit that referenced this issue Apr 27, 2021
@layik layik closed this as completed in #52 Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant