Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

setupTests.sh can't successfully be run without first running setupDesktop.sh #1221

Open
yaronyg opened this issue Sep 30, 2016 · 0 comments

Comments

@yaronyg
Copy link
Member

yaronyg commented Sep 30, 2016

When setupTests.sh runs it depends on things like node_modules having been installed in thali/install. But the setupTests.sh script doesn't do this. The setupDesktop.sh script does though. Normally we don't realize this problem because we either run build.sh (which runs setupDesktop.sh before setupTests.sh) or we run setupDesktop.sh first and then setupTests.sh. But the bug is there. I'm not fixing it now because it's not a priority. But it is embarrassing. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant