store: fix error when bucket cache not used #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default bucketCache is `{}`, which caused a runtime error when
trying to access the `type` field.
Signed-off-by: Craig Furman <craig.furman89@gmail.com>
craigfurman
force-pushed
the
fix-store-without-bucket-cache
branch
from
95ff3f8 to
31e5565
Compare
|
I'm wondering if this is something wrong in storeShards then. The idea is, that if an object is passed to bucketCache it has to have a type field. |
|
Hm. I cannot see anything particularly wrong in the storeShard. I guess I'll go ahead with this to unblock you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
store: fix error when bucket cache not used
The default bucketCache is
{}, which caused a runtime error whentrying to access the
typefield.I only encountered this error when using
thanos.storeShards(), not when usingthanos.store(). I am not sure why this is, the code looks as though it should produce this error instore()too, ifconfig.bucketCacheis unset (and defaults to{}).It looks like #171 fixed a similar problem with query-frontend cache config.
Verification
I've tested this locally (in k3d) with no explicit
config.bucketCache, and one withtype: memcached.