Support compactor hash sharding #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2021 18:23
Signed-off-by: ben.ye <ben.ye@bytedance.com>
Signed-off-by: ben.ye <ben.ye@bytedance.com>
Signed-off-by: ben.ye <ben.ye@bytedance.com>
|
Nice!!! |
|
Hi @metalmatze, thank you for the review. Now I have one service per shard. Do you mean I need to use one service for all statefulsets? Can you explain how would it work via label matching? |
Signed-off-by: ben.ye <ben.ye@bytedance.com>
kakkoyun
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ben.ye ben.ye@bytedance.com
Changes
Fixes #231
Similar to the store shards, I add shards for compactors.
The difference is that store gateway is sharded by
__block_id, but compactor needs to be sharded by the external labels of the blocks (e.g. cluster). This should be configured by users.Verification