jsonnet/manifests/example: Update/generate nodeSelector to kubernetes.io/os instead of beta.kubernetes.io/os #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slashpai
force-pushed
the
update_nodeselector
branch
3 times, most recently
from
13c3c05 to
7182f40
Compare
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
slashpai
force-pushed
the
update_nodeselector
branch
from
7182f40 to
93e56f1
Compare
|
@s-urbaniak @bwplotka Could you please review |
|
lgtm |
squat
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update nodeSelector to kubernetes.io/os since beta.kubernetes.io/os deprecated since v1.14 and shows warning in logs
Verification
NA