Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from circle CI to github actions #253

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 12, 2021

Signed-off-by: Ben Ye ben.ye@bytedance.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work.

It seems like we need disable circleci and enable github actions.

@yeya24
Copy link
Contributor Author

yeya24 commented Nov 24, 2021

@kakkoyun I don't think I have permission to set up Github actions. Are you able to do it?

@metalmatze
Copy link
Member

Done. Merging to unblock and then we should be using GitHub Actions going forward.

@metalmatze metalmatze merged commit 33ac381 into thanos-io:main Dec 9, 2021
@metalmatze
Copy link
Member

Thank you so much for this @yeya24 🎉

@yeya24 yeya24 deleted the switch-github-actions branch December 12, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants