Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hashringConfigmapName to hashringConfigMapName #279

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

michael-burt
Copy link
Contributor

@michael-burt michael-burt commented Jul 14, 2022

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This PR changes hashringConfigmapName to hashringConfigMapName to makes things consistent. This fixes an issue where the configmap name was not properly populated on the receive router pod.

Verification

I tested this in a development cluster.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) once the changelog is fixed we can merge!

@michael-burt michael-burt force-pushed the configmap-typo branch 3 times, most recently from ebab730 to 7cbe3fe Compare July 15, 2022 05:35
Signed-off-by: Michael Burt <michaelpburt@gmail.com>
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @michael-burt 🌟

@squat squat merged commit 5d3901b into thanos-io:main Jul 15, 2022
@michael-burt michael-burt deleted the configmap-typo branch July 15, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants