Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ServiceMonitor for Receive ingestors #280

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

michael-burt
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This PR enables the Receive ingestor ServiceMonitor if it is enabled by the config flag. It fixes an issue where no ServiceMonitor was created even it was enabled in the configuration.

Verification

I tested this out. It does not change default behavior.

@michael-burt michael-burt force-pushed the receive-ingestor-servicemonitor branch 2 times, most recently from 9335503 to 41b98a6 Compare July 18, 2022 15:45
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsonnet/kube-thanos/kube-thanos-receive-ingestor.libsonnet Outdated Show resolved Hide resolved
Signed-off-by: Michael Burt <michaelpburt@gmail.com>
@michael-burt michael-burt force-pushed the receive-ingestor-servicemonitor branch from 41b98a6 to 23e55a9 Compare July 19, 2022 15:07
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @michael-burt

@squat squat merged commit a3f005e into thanos-io:main Jul 19, 2022
@michael-burt michael-burt deleted the receive-ingestor-servicemonitor branch July 19, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants