Fix HTTP auth status codes: return 401 instead of 403 for authentication failures #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HTTP auth status codes: return 401 instead of 403 for authentication failures
Summary
This PR fixes incorrect HTTP status codes in the FastAPI security authentication classes. Previously,
HTTPBase
,HTTPBearer
, andHTTPDigest
were returning403 Forbidden
for missing or malformed authorization headers, but according to HTTP standards,401 Unauthorized
should be used for authentication failures (missing/invalid credentials) while403 Forbidden
should be reserved for authorization failures (valid credentials but insufficient permissions).Key Changes:
HTTPBase.__call__()
to return401
instead of403
for missing authorizationHTTPBearer.__call__()
to return401
instead of403
for missing/invalid bearer tokensHTTPDigest.__call__()
to return401
instead of403
for missing/invalid digest auth401
status codesHTTPBasic
which already correctly used401
Review & Testing Checklist for Human
Diagram
Notes
Link to Devin run: https://app.devin.ai/sessions/dbd89234593447b88a819c77c57825b7
Requested by: @the-coding-gopher