Skip to content

Support for creating new tox environments #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

se02035
Copy link
Contributor

@se02035 se02035 commented Apr 13, 2022

Create tox envs based on configurable env templates.

  • Added new VSCode config section (python-tox.environment.template.new) to specify env templates
  • Env templates support token replacements (using lodash)
  • Added automated tests (incl mocks where user input is required)
  • Updated doc (README.md)

@se02035 se02035 changed the title Create new environment Support for creating new tox environments Apr 14, 2022
@se02035 se02035 marked this pull request as ready for review April 14, 2022 12:53
@se02035
Copy link
Contributor Author

se02035 commented May 4, 2022

@The-Compiler , if you need more information / support to review the PR, please let me know. Happy to help merging the improvements.

@The-Compiler
Copy link
Owner

@se02035 @pkirch @dariuszparys @starlord-daniel Sorry for the loooong delay! This project is something I started to scratch an itch and dabble into Typescript (never used Typescript before, other than a few trivial contributions to other VS Code extensions). I'm glad to hear you find it useful as well and love the contributions, but I totally didn't expect this to happen at all!

Thus, the idea of reviewing so much code in a language I'm quite new to feels quite overwhelming (and there also were some bigger changes in my main project I wanted to finish first - like those things sometimes go, they took a bit longer than anticipated...).

This is all still on my radar, and I plan to take a first look at the PRs today. Hoping that I can already merge some (or even all - we will see!), but I might also have some questions first here and there. Thanks for your patience! 😅

@The-Compiler
Copy link
Owner

Reopening to hopefully trigger CI after f7791a2.

@The-Compiler The-Compiler reopened this Jul 6, 2022
@The-Compiler
Copy link
Owner

I have a preliminary merge of this into the latest main in the merge-snippets branch.

However, after reading through the code and trying the functionality out, I wonder: Isn't this just essentially reinventing the wheel for something which would served much better with an existing VS Code feature, snippets?

They would allow you to do pretty much the same thing, but in a much more interactive way - not only with placeholders for the environment name like now, but also with other placeholders in the template where needed.

@se02035 am I missing something there? Could you elaborate on your use-case for this a bit more?

@The-Compiler The-Compiler added the question Further information is requested label Jul 7, 2022
@The-Compiler
Copy link
Owner

Closing this for now - happy to reconsider if you have an use-case I'm missing which can't be solved in a better way with VS Code snippets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants