-
-
Notifications
You must be signed in to change notification settings - Fork 17
Fix mobile compatibility #3
Comments
I can try and help with this if you assign this issue to me! |
Ok, so, after some testing, turns out that DomeCode is actually pretty responsive on mobile. However, I did notice one graphical glitch, (the "cards" don't align to the center) which I will try to fix. |
Yeah they don't. Another thing, create a local superuser for yourself. Go to the admin and create a resource with a video inside it. The video embed isn't responsive either in the Resources. |
Alright, I'll do those things. |
any updates? |
Hey! Sorry for not getting back to you on this. Work is currently underway to try and re-center the "cards" and fix the video issue. Once those are done, I'll have a look at the resizing issue. Also, the navbar appears transparent on mobile, and so does the drop-down when expanded. I'll see if I can try to fix it. |
the navbar appears transparent only when using safari I guess and that's in the proprietary code. drop the transparency issue, I'll be rolling the fix with some other features. Just try fixing the issues in the open-source version, I'll inherit the fixes from them in the proprietary code base if they seem alright and update the open-source repo with up-to-date code. |
the navbar appears transparent only when using safari
The transparency issue also happens on Firefox Beta on Android for me.
… |
ah okay it's alright tbh, I know the fix for it plus the code causing transparency is not in the open-source repo at the moment. |
Hey, I made a pull request with a requirements.txt file. Please review it and let me know of any changes that might need to be made. |
@arthtyagi Hey, you mentioned something about a fix for the resources issue, but you said you'd have to do it manually for each resource. Can you send me that code? I want to see if I can make it so that it applies automatically to each resource. |
This is the iframe : and this is the fix :
|
Alright, I'll see what I can do. |
#3 - IMPROVEMENT: Create script for fixing video resources on mobile
Alter the front-end to make it look better on mobile devices.
The text was updated successfully, but these errors were encountered: