Remove OAuth client and migrate functionality to static methods. #12
Conversation
| @@ -2,6 +2,7 @@ import Swish | |||
|
|
|||
| /// An API client for Passport. | |||
| public struct APIClient { | |||
| static let auth = Swish.APIClient() | |||
There was a problem hiding this comment.
This name is probably a bit misleading since it's really for making unauthorized requests.
There was a problem hiding this comment.
Not sure what you would name it. client is pretty generic.
|
Hold the phone @paulyoung I see something to take a look at... |
|
Check out https://github.com/nickvelloff/Disc/blob/login-logout/Disc/Networking/Resources/User/LoginIdentity.swift#L36-L80 |
| context("not specifying scopes or a provider") { | ||
| it("should result in login URL") { | ||
| let url = oauth.createLoginUrl() | ||
| let url = APIClient.createLoginUrl(clientId: clientId, redirectUri: redirectUri) | ||
|
|
||
| let expectedUrlString = "https://passport.thegrid.io/login/authorize" |
There was a problem hiding this comment.
This is the old endpoint (OAuth passport) URL
|
This doesn't address any of the new functionality, only what already existed.
Make sense? |
|
I planned to create another pull request for the new endpoints. |
|
Ohh got it. Cool then it looks great. 🚢 |
Remove OAuth client and migrate functionality to static methods.
This is the first part to what was outlined in #11 (comment).
@nickvelloff please review 🙏