Buffer overflow

[bertrandmarc]

Dear developer,

While packaging the 2.15.2 version for Debian, I got a buffer overflow at startup. I seems to come from src/LocaleRes.cpp:110
strcat(codeset, "//TRANSLIT");
I think the length of codeset (hardcoded 16) is too short to fit "ISO-8859-1//TRANSLIT". Changing the length to 30 fixes the buffer overflow (see here).

Best Regards,
Bertrand

[the3dfxdude]

It's already fixed:
5f765d8

Your patch is wrong.

[bertrandmarc]

My patch might not be good, I never claimed it was.

This is anyway not a good reason to be that rude.

[the3dfxdude]

I'm sorry you perceive rudeness. I gave you some information with the hope you'd use it since you are breaking the binary format.